Repository navigation
Conversation
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com> Co-authored-by: TRAE CLI <traecli@bytedance.com>
…chive-closeout-20261107 Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com> Co-authored-by: TRAE CLI <traecli@bytedance.com>
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com> Co-authored-by: TRAE CLI <traecli@bytedance.com>
loopx-agent
left a comment
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent | gpt-6.1-sol | OpenAI | runtime_reported | reasoning_effort=max
[P2] 终结时保留归档 Todo 的原验收证据。 已通过验证、写回并扣账一次后，只修改终结命令的 --evidence，File 和 SQLite 都会写入替换后的证据。返回的仍是原验证回执。随后拿原证据重试会得到幂等回放，Todo 回读却仍指向替换后的证据。归档终结应沿用已接受的 evidence，并拒绝不同的证据参数。 证据写入
动机 / Motivation
执行一轮已验收任务的 Agent 需要完成结算，并能在丢失响应后凭原身份取回结果。 在 101 个 Todo 的合成状态下，普通完成会归档当前 Todo。旧版已写回并扣账一次，终结命令仍报 todo_archived。 用原验收证据重试时，修复版在 File 和 SQLite 上都能终结并回放，验证器、写回和扣账各执行一次。 这次验证覆盖源码 CLI 和两个隔离的权威后端。实际宿主采用和完整成本仍待验。 当前提交还允许在终结时替换已归档的验收证据。
改动思路 / Approach
在既有 TypeScript 生命周期里复用同轮校验，只给归档记录补上终结状态。 新增的入口沿用同轮 fence 和普通完成回执。源文本摘要、原 claim、当前权威状态与 provider CAS 继续约束这次写入。无需改变归档阈值或重跑已验收的任务。当前还要约束复用的终结写入，避免把归档前已有的证据覆盖行为带到归档后。 父回执检查
具体改动 / Changes
关键代码讲解
- readSameTurnCompletionReceipt 从相同 Goal、Todo 和 Turn 找到普通完成回执，并核对原验证。缺失或错配的回执会拒绝。 实现
- executeCoordinationTodoTerminalLifecycle 在拒绝归档 Todo 前允许原 Turn 的终结通过。同轮写回和扣账仍是前置条件。 归档分支
- terminalRequestSha 和 terminalTarget 在普通 Turn 模式下沿用旧摘要，摘要没有绑定 evidence。新分支随后进入共用写入，直接使用调用方提交的证据。 摘要 写入
按 abf1442 的 docs/reference/canonical-terminal-review.md 核对 original-turn-chain、premature-closeout 和 receipt-recovery。原证据路径能按顺序终结并回放。普通完成后、写回扣账前仍会拒绝。与 #8161 集成的四种 File/SQLite 对照也通过，整体 Goal 检查失败时，局部 Todo 可以完成，原 Goal 的失败和检查次数均保留。 原契约
对主干的风险 / Risks
同一真实验证器在两种后端各执行一次。原证据对照保留完成时间、归档状态和一次扣账。替换证据的反例也返回通过的旧回执，因此应额外检查权威 Todo 中的证据字段。基线的 active SQLite 路径已有覆盖行为，基线归档路径拒绝写入。本提交把这条写入扩到了归档记录。请在现有 CLI 回归里加仅变更 --evidence 的反例，再验证原命令仍可终结并回放。 现有回归
语义与 CI 对齐
沿用原 completion_turn 和 no_followup，没有新状态值。10 项 CLI、212 项 TypeScript、类型、Ruff 与快速 premerge 均通过。主干 2659e5f 的合并预检及双语检查通过。严格 CQR 因归档证据反例未通过。PostgreSQL 结果来自作者，托管 CI 按策略保留未知。
我的整体评价 / Verdict
原 Turn 的归档终结恢复值得保留。归档终结应沿用已接受的 evidence，并拒绝不同的证据参数。 可以沿用历史指纹，在新归档分支约束证据字段，保留原验证和回放。改动集中在原生 CLI 结算和 Todo 回读。修订后需复测 File 和 SQLite 的精确输入与证据替换。新提交的 Goal 检查对照已经通过，终结证据覆盖仍可复现。实际安装、采用和完整成本仍待单独验收。
English verdict: REQUEST_CHANGES. Keep the original accepted evidence when closing an archived Todo. Both native backends currently let changed evidence overwrite the archived record while replaying the original validation.
|
This pull request has merge conflicts with Choose the remote for the base repository, not an out-of-date fork. git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEADFor a same-repository clone whose Keep the DCO |
mergify
Bot
added
the
needs-rebase
With 101 Todos, ordinary completion can automatically archive the selected Todo before its original Turn finishes settlement. The later
todo complete --no-follow-upthen fails withtodo_archived, even though completion, writeback and one quota debit are already committed.This repair lets that archived Todo finish the original terminal phase only after the existing same-Turn fence and exact ordinary-completion receipt checks pass. A local TypeScript helper shares those checks between active and archived paths. Task digest, claim/lease, validation receipt, authority and provider CAS checks remain; archive selection and retention thresholds are unchanged. No archived work is reopened.
The proposal integrates main
abf144202(#8161). Its explicit Goal-scoped acceptance checks remain independent of local Todo completion: a real failing Goal checker stays failed after the local validated Todo completes, archives and closes its original Turn. Neither checker is rerun during terminal closeout/replay, and the original completion time, validation receipt and one debit survive.101 个 Todo 时，自动归档会让已完成写回和一次扣账的原 Turn 在最终终结时返回
todo_archived。修复复用既有同 Turn fence 与精确父 receipt 校验。集成 #8161 后，新增真实 CLI 案例证明：整体 Goal 检查失败时，局部 Todo 仍可按自身 validator 完成和终结；整体检查继续失败，终结与回放不重复执行 checker 或扣账。Validation at
12627eff8005b900d8c1b99589de02a8a481a8aaagainstorigin/main(abf144202):The baseline lifecycle failures and the earlier frozen cost comparison remain failures. Earlier fixture assertions used the wrong archive token and the first disposable PostgreSQL startup exceeded the Unix socket path limit; those setup results are preserved separately from the passing qualification.
The paired RFC checkpoint records the proposed repair and latest-main integration. Independent exact-head review and reviewed-repair monolithic-wheel readback remain pending. Installed-host upgrade, interruption/restart, split installation, full R0/V10/R1, M1, context/model composition and complete-cost/adoption acceptance remain open. I3 retains at least one minor release. The same helper is the bounded refactor; no parallel Python owner or new preset/default/provider selection is introduced.
This author proposal does not grant merge authority. No merge into main or installed-host upgrade was performed.